Honest criticism or pat on the back? Here's your pat on the back:
You obviously spent a LOT of time on this. Well done on your part. The audio is very clear and the mod is done correctly. +1 for including the source code.
Now, stop reading if you don't want the honest criticism....
The pack is almost 14MB. Way too big but I see why that is, and I'll get to that in a moment. The choices are good but probably 2/3rds are just quite simply too long to be used. In a normal game they are going to be interrupted by the next voice whether bot or player. They should not be longer than 3 or 4 seconds each, and this is a hard and fast rule because the game will enforce it. Nothing ruins a good voice pack more than to have messages constantly never finish. Most VP makers don't grasp this idea and they all make "speech" taunts that go unused instead of "Slam" taunts that get spammed because they are short and simple. I mean who doesn't use "Boom!" almost all the time instead of the longer default taunts?
Your sample rate is too high too. Drop it and your pack size will rapidly fall too. You need to get this beast under 3 or 4 MB before it will be taken seriously (which it should because it's
damn good choices).
Lastly you have this in your code in several spots:
Code: Select all
AckString(8)="Yeah, you know what, that's a pointless argument right there. That's like if your dad said, "I fucked your mom." It's like: "I can't argue with that!""
You can't have multiple "" in the same line. The game thinks there are multiple lines to print in this one line because of it. Make them:
Code: Select all
AckString(8)="Yeah, you know what, that's a pointless argument right there. That's like if your dad said: I fucked your mom!..It's like: I can't argue with that!"
And these lines are just too long but it's because the individual taunts need seriously trimmed down and one will fix the other.
You also have some errors in the code like:
line 202:
Code: Select all
FFireSound(0)=Sound'AVGNVP.AVGNVP.assSound'AVGNVP.AVGNVP.assaholic'
If you decide to redo this proper then let me know and I'll fix your code so it works. Your VP bugs are caused by it but they can be fixed.
BTW admins, apologies if the quoted language is improper for the forum. I will edit it out if it's offensive and defies the forum rules.
