MapVoteLAv21 beta2
-
- Adept
- Posts: 426
- Joined: Tue Feb 21, 2012 7:29 pm
Re: MapVoteLAv21 beta
That is not quite what I have in mind but that is a very excellent idea Kelly and you should make it happen.
-
- Godlike
- Posts: 3774
- Joined: Fri Jan 14, 2011 1:53 pm
- Personal rank: -Retired-
Re: MapVoteLAv21 beta
I think I will but it's going to be for my Unreal coop server. That's all I really play any more (when I can find it empty).
So long, and thanks for all the fish
Re: MapVoteLAv21 beta
@sektor2111, thanks for remarks. All this applies only to the class BDBMapVote?
This means I can remove "P.bIsPlayer"?sektor2111 wrote:Missing sanity check hereIf we call PlayerReplicationInfo probably we want to be sure about its existence. bIsPlayer is a fast check but is a bullshit in original since a smart was developing monsters with bIsPlayer and not PlayerReplicationInfo messing up Game-LOG file and all UT stuff - so no, again, is not compatible will all game-types :/.Code: Select all
JL02DF: if ( P != None ) { if ( P.bIsPlayer && ((BestP == None) || (P.PlayerReplicationInfo.Score > BestP.PlayerReplicationInfo.Score)) ) { BestP=P; } P=P.nextPawn; goto JL02DF; } P=Level.PawnList;
- sektor2111
- Godlike
- Posts: 6403
- Joined: Sun May 09, 2010 6:15 pm
- Location: On the roof.
Re: MapVoteLAv21 beta
I'll explain additional problems a bit later. What I consider is P.bIsplayer should be P.PlayerReplicationInfo != None. I did not check if is faster (I guess not) but is safer. Everywhere I rewritten that thing which at this moment I consider it useless - it's a trouble-maker.
Whatever Coop games or extended DM using Monsters pawns - or maps having some Skaarj will have chances to do only couple of troubles as long as default Skaarj won't respawn/win game.
And now if Pawn is bIsPlayer but It doesn't have a PlayerReplicationInfo then everything calling that will do errors - but everything.
Redeemer, BotOrders, AddToTeam, main ScoreKill from engine, Killed, Bot, other weaponry and not the last thing is that old NetSpeed stuff doing a check at Bot and Monsters which never uses a NetConnection .
At least a new map-vote opens options for better codes - I recall one check <if P.bIsPlayer && PlayerPawn(P) != None>. My question is if anyone could ever see a PlayerPawn which is not bIsPlayer .
History:
Engine.PawnThis happens too fast before Auto State, so Monster is not bIsPlayer yet. But later, after passing prebeginplay. SkaarjTrooper crap:
So this prototype of pawn goes messed later - doesn't have name score spree - just nothing as long as PrebeginPlay passed.
Auto State get called after PostBeginPlay as described at Wiki.
Edit: I have WeaponHolders which are not messing any bIsPlayer crap, and they work properly so... that old deal was a very bad move after all.
Whatever Coop games or extended DM using Monsters pawns - or maps having some Skaarj will have chances to do only couple of troubles as long as default Skaarj won't respawn/win game.
And now if Pawn is bIsPlayer but It doesn't have a PlayerReplicationInfo then everything calling that will do errors - but everything.
Redeemer, BotOrders, AddToTeam, main ScoreKill from engine, Killed, Bot, other weaponry and not the last thing is that old NetSpeed stuff doing a check at Bot and Monsters which never uses a NetConnection .
At least a new map-vote opens options for better codes - I recall one check <if P.bIsPlayer && PlayerPawn(P) != None>. My question is if anyone could ever see a PlayerPawn which is not bIsPlayer .
History:
Engine.Pawn
Code: Select all
event PreBeginPlay()
{
....
if (bIsPlayer)
{
if (PlayerReplicationInfoClass != None)
PlayerReplicationInfo = Spawn(PlayerReplicationInfoClass, Self,,vect(0,0,0),rot(0,0,0));
else
PlayerReplicationInfo = Spawn(class'PlayerReplicationInfo', Self,,vect(0,0,0),rot(0,0,0));
InitPlayerReplicationInfo();
}
Code: Select all
function BeginState()
{
Super.BeginState();
bIsPlayer = true; // temporarily, till have weapon - > what if doesn't have weapontype ? Still trash !
// maybe tomorrow if somehow mess ChangedWeapon() call or will stay as a trash bugging everything
if ( WeaponType != None )
{
bIsPlayer = true; //Twice called
myWeapon = Spawn(WeaponType);
if ( myWeapon != None )
myWeapon.ReSpawnTime = 0.0;
}
}
Auto State get called after PostBeginPlay as described at Wiki.
Edit: I have WeaponHolders which are not messing any bIsPlayer crap, and they work properly so... that old deal was a very bad move after all.
Re: MapVoteLAv21 beta2
MapVoteLAv21_beta2:
*Added free space on top for a chat
*Some fixes
*Added free space on top for a chat
*Some fixes
- Attachments
-
- MapVoteLAv21_beta2.zip
- (94.62 KiB) Downloaded 77 times