XServerQuery

[Deaod]

Whats the problem with it?

EDIT: I've found an infinite loop that was crashing my servers (probably my own change at fault, but the code in XServerQuery is also pretty dumb), so therell be another version.

[Eternity]

Whats the problem with it?

It should not be used as index for 'ChallengeBotInfo' "Skills" array. "Difficulty" variable from 'ChallengeBotInfo' should be used instead.

[Deaod]

Given that the base-game DeathMatchPlus does exactly the same ... im not going to argue with it, and leave this untouched i think. Btw, DeathMatchPlus.SpawnBot changes Level.Game.Difficulty to (what i think will just be ChallengeBotInfo).Difficulty.

Anyway, 2.03: Fixed an infinite loop.

[Buggie]

I'm still hopi that someone will put the option to add dns, only numbers are obsolete....

Look like you need this: https://github.com/OldUnreal/UnrealTour ... issues/171
If so, then it can be fixed in v469c.

Given that the base-game DeathMatchPlus does exactly the same ... im not going to argue with it, and leave this untouched i think. Btw, DeathMatchPlus.SpawnBot changes Level.Game.Difficulty to (what i think will just be ChallengeBotInfo).Difficulty.

You mean this https://github.com/OldUnreal/UnrealTour ... /issues/85 ?

[Deaod]

Ah, good point.

2.04: Fix BotSkill value

[sektor2111]

GameInfo is GameInfo and Bot is Bot

Code: Select all

class GameInfo extends Info
	native;
var byte  Difficulty;									// 0=easy, 1=medium, 2=hard, 3=very hard.

For GitHub "coders" Level Game has MAX 3 probably they do not have any clue how to decompile UScript...
Relevance code

Code: Select all

...
	if
	(	(Difficulty==0 && !Other.bDifficulty0 )
	||  (Difficulty==1 && !Other.bDifficulty1 )
	||  (Difficulty==2 && !Other.bDifficulty2 )
	||  (Difficulty==3 && !Other.bDifficulty3 )
	||  (!Other.bSinglePlayer && (Level.NetMode==NM_Standalone) ) 
	||  (!Other.bNet && ((Level.NetMode == NM_DedicatedServer) || (Level.NetMode == NM_ListenServer)) )
	||  (!Other.bNetSpecial  && (Level.NetMode==NM_Client)) )
		return False;
...

It's all about up to Level 3.
And Pawn

Code: Select all

class Pawn extends Actor 
	abstract
	native
	nativereplication;
...
var(AI) float		Skill;			// skill, scaled by game difficulty (add difficulty to this value)
...
	if ( Level.Game != None )
		Skill += Level.Game.Difficulty; 
	Skill = FClamp(Skill, 0, 3);

Code clamps Pawn at 3.
And Bot

Code: Select all

function InitializeSkill(float InSkill)
{
	Skill = InSkill;
	bNovice = ( Skill < 4 );
	if ( !bNovice )
		Skill -= 4;
	Skill = FClamp(Skill, 0, 3);
	ReSetSkill();
}

function ReSetSkill()
{
	//log(self$" at skill "$Skill$" novice "$bNovice);
	bThreePlus = ( (Skill >= 3) && Level.Game.IsA('DeathMatchPlus') && DeathMatchPlus(Level.Game).bThreePlus );
	bLeadTarget = ( !bNovice || bThreePlus );
	if ( bNovice )
		ReFireRate = Default.ReFireRate;
	else
		ReFireRate = Default.ReFireRate * (1 - 0.25 * skill);

	PreSetMovement();
}

It's why Bot must have a ChallengeBotInfo deal, not GameInfo, or else it will never show GodLike bots.

[[rev]rato.skt]

how cool, what good news! Thanks

I'm still hopi that someone will put the option to add dns, only numbers are obsolete....

Look like you need this: https://github.com/OldUnreal/UnrealTour ... issues/171
If so, then it can be fixed in v469c.

[(G)ott]

Version 2.1.0

Changelog:

Code: Select all

from 201 to 210
- added optional timestamp log.
- added config bShowTimeStamp & bShowAdvancedTimeStamp.
- fixed time check on query request.
- added config iNumSecToBlockIP.
- changed config iNumPacketsBeforLog to iNumPacketsBeforBlock !!
- fixed players country memory.
- removed querytype "NewNet".
- changed config bShowProtection is now by default "hidden".
- changed querytype "Protection" - it has now only focus to ACE.
- some small changes and cleanups.

Download on top post. -> fast trace


greetz (G)ott

[(G)ott]

Version 2.1.1

Changelog:

Code: Select all

from 210 to 211
- fixed server will not shown, when ACE is installed and bShowProtection=true.

Stupid Bug

Download on top post. -> fast trace


greetz (G)ott

[asosed]

(G)ott, did you fix the bot skill display issue that deaod fixed? viewtopic.php?f=34&t=6061&start=15#p127295 I see that the problem remains
And this problem "XServerQuery starts ignoring requests soon after mightnight according to real-time-clock of the server." viewtopic.php?f=34&t=6061#p127233

[bearbeardut99]

hello there !

I have been running xserverquery for a long time, but something is not right in my settings that i can't visualize the country flag of my own server. i have no problems when seeing flags from players but from the server itself it just won`t show up. Am I missing something ? I would appreciate some help.

thanks for the effort to keep ut99 alive and fun

[(G)ott]

(G)ott, did you fix the bot skill display issue that deaod fixed? viewtopic.php?f=34&t=6061&start=15#p127295 I see that the problem remains

I'm sorry but I don't agree with this solution. There are two reasons:
- "Game Info" ist not the place to show the bots inividual skill. Maybe i will add a new colum in the PlayerInfo of the XBrowser which shows the skill, if its a bot.
- I think that "Bot Skill" is in Unreal a number between 0-3 and should be expanded to 0-7 in UT, but was cancelled. Skill is always FClamp(Skill, 0, 3). Maybe i will rename "Bot Skill" to "Difficulty" and set the output to "easy", "medium", "hard" or "very hard" (or similar).

Code: Select all

class DeathMatchPlus extends TournamentGameInfo config;
...
function string GetRules()
{
...
		Resultset = ResultSet$"\\botskill\\"$class'ChallengeBotInfo'.default.Skills[Difficulty];
...
}
...

Code: Select all

class GameInfo extends Info native;

var byte  Difficulty;									// 0=easy, 1=medium, 2=hard, 3=very hard.
...

Code: Select all

class UMenuNewGameClientWindow extends UMenuPageWindow;
...
defaultproperties
{
     ...
     SkillText="Skill Level:"
     Skills(0)="Easy"
     Skills(1)="Medium"
     Skills(2)="Hard"
     Skills(3)="Unreal"
     ...
}

Code: Select all

class UMenuBotConfigBase extends UMenuPageWindow;
...
defaultproperties
{
     BaseText="Base Skill:"
     BaseHelp="This is the base skill level of the bots."
     Skills(0)="Novice"
     Skills(1)="Average"
     Skills(2)="Skilled"
     Skills(3)="Masterful"
     ...
}

At the moment im a bit busy, so a new version of both Mods will not come in the next time.

And this problem "XServerQuery starts ignoring requests soon after mightnight according to real-time-clock of the server." viewtopic.php?f=34&t=6061#p127233

should be fixed

Code: Select all

from 201 to 210
- fixed time check on query request.

hello there !

I have been running xserverquery for a long time, but something is now right in my settings that i can´t visualize the country flag of my own server. i have no problems when seeing flags from players but from the server itself it just won`t show up. Am I missing something ? I would appreciate some help.

thanks for the effort to keep ut99 alive and fun

Have you tried changing the "netAddress" manually in the XSQ ?

like:

Code: Select all

[XServerQuery.XServerQuery]
netAddress=45.225.92.93

If so, has it changed to another IP?

[Que]

Have you tried changing the "netAddress" manually in the XSQ ?

This doesn't work for me either.

[Deaod]

(G)ott, did you fix the bot skill display issue that deaod fixed? viewtopic.php?f=34&t=6061&start=15#p127295 I see that the problem remains

I'm sorry but I don't agree with this solution. There are two reasons:
- "Game Info" ist not the place to show the bots inividual skill. Maybe i will add a new colum in the PlayerInfo of the XBrowser which shows the skill, if its a bot.
- I think that "Bot Skill" is in Unreal a number between 0-3 and should be expanded to 0-7 in UT, but was cancelled. Skill is always FClamp(Skill, 0, 3). Maybe i will rename "Bot Skill" to "Difficulty" and set the output to "easy", "medium", "hard" or "very hard" (or similar).

I'm not sure what the problem is with fixing this. Difficulty is set depending on BotInfo.Difficulty. The label of the value in the query response is BotSkill and should thus IMO reflect the setting the user chose for the skill of bots. Restoring that information seems like a pure bugfix to me.

Please take another look at the code surrounding the Difficulty setting. I know its tangled up with everything, but youll eventually see that the fix works and has minimal side-effects.

"Bot Skill" is a number between 0 and 3, yes, but there is also a bNovice (Bots), or bNoviceMode (Game) variable that effectively doubles the number of difficulty settings. Taken together UT absolutely supports 8 different skill settings for bots, and XServerQuery should respond with the setting the admin chose.

EDIT: For what its worth, the change buggie proposed has been integrated into 469c.

[Que]

@(G)ott perhaps you could add to .ini an option to set flag prefix ie: AU
Which would display the Australian Flag next to server in UBrowser.