Need add forum plugin which merge posts

Do you want to say something about UT99.org?
User avatar
Metalfist
Masterful
Posts: 632
Joined: Sun Jan 03, 2010 3:54 pm
Personal rank: ^,..,^ rawr

Re: Need add forum plugin which merge posts

Post by Metalfist »

I'm talking in general here, so not specifically about this mod, but it's not an "excuse", it is a real problem that I have experienced before so don't pretend it's not a possible problem just because you can't see it on the front end. And it can be a hassle to remove all the code from the php files, which in turn can cause problems with other code. The more you add, the more risks you build in (including security risks). Yes it can run for a while, but in the long run it can fall apart like a house of cards. You don't want the same happen like with beyondunreal (broken database). It's important to see these risks too for the longevity of the forum.
Image
User avatar
esnesi
Godlike
Posts: 1020
Joined: Mon Aug 31, 2015 12:58 pm
Personal rank: Dialed in.

Re: Need add forum plugin which merge posts

Post by esnesi »

Metalfist wrote: Sun May 30, 2021 2:30 am
If certain issues can be automated, which occur quite a lot, then why not ?
It is handy, but there are downsides. More mods and plugins can create more instabilities and issues when trying to update the forum software for example.
You always need to test something before using it.
That is quite logical.

If such a plugin offers instability and updates issues, those would or should be mentioned somewhere.
User avatar
Feralidragon
Godlike
Posts: 5498
Joined: Wed Feb 27, 2008 6:24 pm
Personal rank: Work In Progress
Location: Liandri

Re: Need add forum plugin which merge posts

Post by Feralidragon »

Well, it's been years since I last peeked into the phpBB source code, and it's still at the same levels of awful unfortunately.

It still targets PHP 5.3, which last release was almost 7 years ago, which already opens some potential security vulnerabilities by itself, and then the whole thing is still built in such an old way that it hurts my soul just reading it, which makes it very hard to update without breaking, and it's fairly fragile security-wise (if you don't know exactly what you're doing, you will be opening the forum to all sorts of security issues).

So I can understand Metalfist's concerns to a good degree.
Code like this is not easy to upgrade and modify without compromising security and compatibility with future updates, it's that bad.

Having that said though, as long as the mods are PHP-side only, and they don't actually change anything in the database itself, it will always be possible to migrate to future phpBB versions.
And something like an auto-merge feature should be something fairly easy to do involving nothing else other than PHP-side extensions or mods, and which will at most disappear with an update, at which point it just needs to be done again, but it won't really break anything or make the forum security worse than it already is.

So I would say, just go for it.

If you have concerns, you can link me to the code itself, and once I have a bit of time I can review to tell whether or not the code is reliable.
I don't know almost anything about phpBB itself, as I never used it myself and its code quality also acts a repellent for me, but I have been doing PHP programming for almost 10 years now, so I can at least review it.
User avatar
Shade
Site Admin
Posts: 1481
Joined: Sun Jan 27, 2008 12:03 pm
Personal rank: Founder of UT99.org
Location: Germany

Re: Need add forum plugin which merge posts

Post by Shade »

Metalfists arguments are valid. However, in this case the plugin is pretty compact and the usefulness worth the very slim risks. At least for the moment.
Auto merging is enabled. If you encounter any problems, please let me know. Auto merging can also be deactivated individually for certain threads, if necessary.
UT99.org Discord Server: https://discord.gg/6CP2UjZ
UT Server Browser: https://ut99.org/servers
User avatar
Barbie
Godlike
Posts: 2848
Joined: Fri Sep 25, 2015 9:01 pm
Location: moved without proper hashing

Re: Need add forum plugin which merge posts

Post by Barbie »

Auto merge does not respect HTML code (see this thread for example).
You do not have the required permissions to view the files attached to this post.
"If Origin not in center it be not in center." --Buggie
User avatar
papercoffee
Godlike
Posts: 10466
Joined: Wed Jul 15, 2009 11:36 am
Personal rank: coffee addicted !!!
Location: Cologne, the city with the big cathedral.

Re: Need add forum plugin which merge posts

Post by papercoffee »

Barbie wrote: Sun Mar 26, 2023 9:15 am Auto merge does not respect HTML code (see this thread for example).
I don't see what's the problem... That line is only set in colour green.
User avatar
OjitroC
Godlike
Posts: 3708
Joined: Sat Sep 12, 2015 8:46 pm

Re: Need add forum plugin which merge posts

Post by OjitroC »

papercoffee wrote: Mon Mar 27, 2023 1:08 pm
Barbie wrote: Sun Mar 26, 2023 9:15 am Auto merge does not respect HTML code (see this thread for example).
I don't see what's the problem... That line is only set in colour green.
The HTML code has been printed as

Code: Select all

 "hidden&quot
rather than implemented as

Code: Select all

"hidden"
I did notice that after I had posted that update/auto merge and thought it rather odd.
User avatar
papercoffee
Godlike
Posts: 10466
Joined: Wed Jul 15, 2009 11:36 am
Personal rank: coffee addicted !!!
Location: Cologne, the city with the big cathedral.

Re: Need add forum plugin which merge posts

Post by papercoffee »

hm ... let me test it.   
Auto merged new post submitted later

"hidden"   
Auto merged new post submitted later

"hidden"
   
Auto merged new post submitted 2 minutes later

"hidden"   
Auto merged new post submitted 1 minute later

In the last line I used exactly your html snipped ... :noidea

EDIT-----------------------------
I rearranged the lines now for better readability. Still no strange behaviour.   
Auto merged new post submitted 3 minutes later
Re: "hidden" last test.
User avatar
OjitroC
Godlike
Posts: 3708
Joined: Sat Sep 12, 2015 8:46 pm

Re: Need add forum plugin which merge posts

Post by OjitroC »

Oh well, must have been something I did. 
User avatar
Barbie
Godlike
Posts: 2848
Joined: Fri Sep 25, 2015 9:01 pm
Location: moved without proper hashing

Re: Need add forum plugin which merge posts

Post by Barbie »

Try it in subject.
"If Origin not in center it be not in center." --Buggie